fix: Ruff rule RET506 (superfluous-else-raise) #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boriel
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
I agree with this fix, however this file is provided by an external source-only library:
https://github.com/dabeaz/ply/blob/master/src/ply/yacc.py#L868
And this error will reappear over and over (along with the others) whenever I copy new versions of this library again (very unlikely, because this code is frozen and will only be updated in case of bugs).
EDIT: Since this file is not of mine, I don´t plan to update in the mid-term.
Feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.astral.sh/ruff/rules/superfluous-else-raise/