Skip to content

fix(zui): descriptions not restored from JSON schemas #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2025
Merged

fix(zui): descriptions not restored from JSON schemas #654

merged 2 commits into from
Nov 1, 2025

Conversation

@slvnperron
Copy link
Member

@slvnperron slvnperron commented Nov 1, 2025 •
edited
Loading

Added a bunch of tests to Zui and fixed two issues:

  1. descriptions were not restored in Zui types from JSON Schemas
  2. .default() types were not correctly unwrapped when optional

@slvnperron slvnperron requested review from a team and franklevasseur as code owners November 1, 2025 20:21
@slvnperron slvnperron merged commit 3adcf53 into master Nov 1, 2025
1 check passed
@slvnperron slvnperron deleted the sp/zui-desriptions branch November 1, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chsir17 chsir17 chsir17 approved these changes

@franklevasseur franklevasseur Awaiting requested review from franklevasseur

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slvnperron @chsir17