Skip to content

Conversation

@EFF
Copy link
Contributor

@EFF EFF commented Oct 24, 2022

This PR fixes 2 issues that are mentioned here

1- It prevent to fetch invalid or undefined content element (the issue causing the 504)
2- Properly initializes the content type selector form when the category is already defined. (Issue is coming from the fact that I brought this piece of code from cloud studio which has a different behavior)

before: forever spinning wheel
Screen Shot 2022-10-24 at 12 13 47 PM

before: create or select content item=
Screen Shot 2022-10-24 at 12 12 06 PM

@EFF EFF requested a review from davidvitora October 24, 2022 16:19
Copy link
Contributor

@davidvitora davidvitora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EFF EFF merged commit f713de1 into master Oct 24, 2022
@EFF EFF deleted the f_fix-content-type-selector branch October 24, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants