This repository was archived by the owner on Apr 17, 2019. It is now read-only.
Fixes: Returning 403 from non-auth messages would trigger retrying login, even for non-authed users #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sages would trigger retrying login This would result in a crash if no username was set. In this case, if the session has not initiated a login (AuthStateNoAuth) it will not try to login again.
boundsj
added a commit
that referenced
this pull request
Feb 5, 2014
Owner
|
Thanks for this. Your change caused 3 tests to fail since the tests were naive about login context. While fixing them I realized that it's probably better to (simply) only try login when in the correct context and that is only "auth state logging in". I pushed those changes 4253c97 so the issue raised by this PR should be fixed. I'm going to close this now - thanks again!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would result in a crash if no username was set. In this case, if
the session has not initiated a login (AuthStateNoAuth) it will not try
to login again.