fix(scroll): support scrollToAnnotation from parent (#503)

mickr · mergify[bot] · web-flow · commit 11ccda0b24b0 · 2020-06-01T19:52:08.000Z
* fix(scroll): support scrollToAnnotation from parent
* Change function signature of scrollToAnnotation to support receiving an annotation instead of an id.
* Remove logic that gets the annotation from the store and uses the provided annotation to scroll.

* fix(scroll): support scrollToAnnotation from parent

* PR Feedback, reverted to the original code as to not over complicate by changing the function signature.

* fix(scroll): support scrollToAnnotation from parent

* Fix lint issue

Co-authored-by: mergify[bot] &lt;37929162+mergify[bot]@users.noreply.github.com&gt;
diff --git a/src/common/BaseAnnotator.ts b/src/common/BaseAnnotator.ts
@@ -109,7 +109,6 @@ export default class BaseAnnotator extends EventEmitter {
 
     public setActiveId(annotationId: string | null): void {
         this.store.dispatch(store.setActiveAnnotationIdAction(annotationId));
-        this.scrollToAnnotation(annotationId); // TODO: Require parent to call separately
     }
 
     public setVisibility(visibility: boolean): void {

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,6 @@ export default class BaseAnnotator extends EventEmitter {`
`109`	`109`
`110`	`110`	`public setActiveId(annotationId: string \| null): void {`
`111`	`111`	`this.store.dispatch(store.setActiveAnnotationIdAction(annotationId));`
`112`		`- this.scrollToAnnotation(annotationId); // TODO: Require parent to call separately`
`113`	`112`	`}`
`114`	`113`
`115`	`114`	`public setVisibility(visibility: boolean): void {`