chore(highlight): Remove highlight text feature option (#638)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: Conrad Chan

src/document/DocumentAnnotator.ts

@@ -30,9 +30,7 @@ export default class DocumentAnnotator extends BaseAnnotator {
     constructor(options: Options) {
         super(options);
 
-        if (this.isFeatureEnabled('highlightText')) {
-            this.highlightListener = new HighlightListener({ getSelection, store: this.store });
-        }
+        this.highlightListener = new HighlightListener({ getSelection, store: this.store });
 
         this.addListener(Event.ANNOTATIONS_MODE_CHANGE, this.handleChangeMode);
     }
@@ -76,23 +74,21 @@ export default class DocumentAnnotator extends BaseAnnotator {
                 managers.add(new DrawingManager({ location: pageNumber, referenceEl: pageReferenceEl }));
             }
 
-            if (this.isFeatureEnabled('highlightText')) {
-                const textLayer = pageEl.querySelector('.textLayer') as HTMLElement;
-
-                if (textLayer) {
-                    managers.add(
-                        new HighlightCreatorManager({
-                            getSelection,
-                            referenceEl: textLayer,
-                            selectionChangeDelay: TEXT_LAYER_ENHANCEMENT,
-                            store: this.store,
-                        }),
-                    );
-                }
-
-                managers.add(new HighlightManager({ location: pageNumber, referenceEl: pageReferenceEl }));
+            const textLayer = pageEl.querySelector('.textLayer') as HTMLElement;
+
+            if (textLayer) {
+                managers.add(
+                    new HighlightCreatorManager({
+                        getSelection,
+                        referenceEl: textLayer,
+                        selectionChangeDelay: TEXT_LAYER_ENHANCEMENT,
+                        store: this.store,
+                    }),
+                );
             }
 
+            managers.add(new HighlightManager({ location: pageNumber, referenceEl: pageReferenceEl }));
+
             managers.add(new RegionManager({ location: pageNumber, referenceEl: pageReferenceEl }));
 
             const canvasLayerEl = pageEl.querySelector<HTMLElement>('.canvasWrapper');

src/document/__tests__/DocumentAnnotator-test.ts

@@ -76,20 +76,16 @@ describe('DocumentAnnotator', () => {
     });
 
     describe('constructor()', () => {
-        test('should not create HighlightListener if feature is not enabled', () => {
-            expect(annotator.highlightListener).toBeUndefined();
-        });
-
-        test('should create HighlightListener if feature is enabled', () => {
-            annotator = getAnnotator({ features: { highlightText: true } });
+        test('should create HighlightListener', () => {
+            annotator = getAnnotator();
 
             expect(annotator.highlightListener).toBeInstanceOf(HighlightListener);
         });
     });
 
     describe('destroy()', () => {
         test('should remove event handler ', () => {
-            annotator = getAnnotator({ features: { highlightText: true } });
+            annotator = getAnnotator();
 
             jest.spyOn(annotator, 'removeListener');
             jest.spyOn(annotator.highlightListener as HighlightListener, 'destroy');
@@ -138,25 +134,14 @@ describe('DocumentAnnotator', () => {
             const managers = annotator.getPageManagers(getPage());
             const managerIterator = managers.values();
 
-            expect(managerIterator.next().value).toBeInstanceOf(PopupManager);
-            expect(managerIterator.next().value).toBeInstanceOf(RegionManager);
-            expect(managerIterator.next().value).toBeInstanceOf(RegionCreationManager);
-        });
-
-        test('should create HighlightManager if feature is enabled', () => {
-            annotator = getAnnotator({ features: { highlightText: true } });
-
-            const managers = annotator.getPageManagers(getPage());
-            const managerIterator = managers.values();
-
             expect(managerIterator.next().value).toBeInstanceOf(PopupManager);
             expect(managerIterator.next().value).toBeInstanceOf(HighlightManager);
             expect(managerIterator.next().value).toBeInstanceOf(RegionManager);
             expect(managerIterator.next().value).toBeInstanceOf(RegionCreationManager);
         });
 
-        test('should create HighlightCreatorManager if feature is enabled and textLayer is present', () => {
-            annotator = getAnnotator({ features: { highlightText: true } });
+        test('should create HighlightCreatorManager if textLayer is present', () => {
+            annotator = getAnnotator();
 
             const managers = annotator.getPageManagers(getPage(2));
             const managerIterator = managers.values();

test/index.html

@@ -56,7 +56,7 @@
                 }
 
                 /* global BoxAnnotations */
-                var annotations = new BoxAnnotations(null, { features: { highlightText: true } });
+                var annotations = new BoxAnnotations(null);
 
                 /* global Box */
                 var preview = new Box.Preview();