Skip to content

Commit 53b00bd

Browse files
author
Mingze
authored
fix(ie): Remove selection type check (#574)
1 parent 946d9f0 commit 53b00bd

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

src/document/__tests__/docUtil-test.ts

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,18 @@ describe('docUtil', () => {
3838
});
3939

4040
describe('getRange()', () => {
41+
const mockSelection = {
42+
getRangeAt: () => 'range',
43+
isCollapsed: false,
44+
rangeCount: 1,
45+
};
46+
4147
test.each`
42-
selection | result
43-
${null} | ${null}
44-
${{ type: 'Caret' }} | ${null}
45-
${{ isCollapsed: true, type: 'Range' }} | ${null}
46-
${{ isCollapsed: true, rangeCount: 0, type: 'Range' }} | ${null}
47-
${{ getRangeAt: () => 'range', rangeCount: 1, type: 'Range' }} | ${'range'}
48+
selection | result
49+
${null} | ${null}
50+
${{ ...mockSelection, isCollapsed: true }} | ${null}
51+
${{ ...mockSelection, rangeCount: 0 }} | ${null}
52+
${mockSelection} | ${'range'}
4853
`('should return range as $result', ({ selection, result }) => {
4954
jest.spyOn(window, 'getSelection').mockImplementationOnce(() => selection);
5055

src/document/docUtil.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ export function getPageNumber(element: Element | null): number | undefined {
2929

3030
export function getRange(): Range | null {
3131
const selection = window.getSelection();
32-
if (!selection || selection.type !== 'Range' || selection.isCollapsed || !selection.rangeCount) {
32+
33+
if (!selection || selection.isCollapsed || !selection.rangeCount) {
3334
return null;
3435
}
3536

0 commit comments

Comments
 (0)