fix(highlight): Reset selection when creator status changes (#612)

* fix(highlight): Reset selection when creator status changes

* fix(highlight): Address comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: Mingze

src/store/highlight/__tests__/reducer-test.ts

@@ -4,20 +4,15 @@ import { Annotation, NewAnnotation } from '../../../@types';
 import { createAnnotationAction } from '../../annotations';
 import { mockContainerRect, mockRange } from '../__mocks__/data';
 import { Mode, toggleAnnotationModeAction } from '../../common';
-import { resetCreatorAction } from '../../creator';
+import { CreatorStatus, resetCreatorAction, setStatusAction } from '../../creator';
 import { setIsPromotingAction, setSelectionAction, setIsSelectingAction } from '../actions';
 
 describe('store/highlight/reducer', () => {
     describe('setIsPromoting', () => {
-        test.each`
-            payload  | isPromoting | selection
-            ${true}  | ${true}     | ${null}
-            ${false} | ${false}    | ${state.selection}
-        `('should set isPromoting and selection in state', ({ isPromoting, payload, selection }) => {
+        test.each([true, false])('should set isPromoting in state as %s', payload => {
             const newState = reducer(state, setIsPromotingAction(payload));
 
-            expect(newState.isPromoting).toEqual(isPromoting);
-            expect(newState.selection).toEqual(selection);
+            expect(newState.isPromoting).toEqual(payload);
         });
     });
 
@@ -64,4 +59,12 @@ describe('store/highlight/reducer', () => {
             expect(newState.isPromoting).toEqual(false);
         });
     });
+
+    describe('setStatusAction', () => {
+        test('should reset selection when creator status changes', () => {
+            const newState = reducer(state, setStatusAction(CreatorStatus.started));
+
+            expect(newState.selection).toEqual(null);
+        });
+    });
 });

src/store/highlight/reducer.ts

@@ -1,7 +1,7 @@
 import { createReducer } from '@reduxjs/toolkit';
 import { createAnnotationAction } from '../annotations';
 import { HighlightState } from './types';
-import { resetCreatorAction } from '../creator';
+import { resetCreatorAction, setStatusAction } from '../creator';
 import { setIsPromotingAction, setIsSelectingAction, setSelectionAction } from './actions';
 import { toggleAnnotationModeAction } from '../common';
 
@@ -15,9 +15,6 @@ export default createReducer<HighlightState>(initialState, builder =>
     builder
         .addCase(setIsPromotingAction, (state, { payload }) => {
             state.isPromoting = payload;
-            if (payload) {
-                state.selection = null;
-            }
         })
         .addCase(setIsSelectingAction, (state, { payload }) => {
             state.isSelecting = payload;
@@ -33,5 +30,8 @@ export default createReducer<HighlightState>(initialState, builder =>
         })
         .addCase(toggleAnnotationModeAction, state => {
             state.isPromoting = false;
+        })
+        .addCase(setStatusAction, state => {
+            state.selection = null;
         }),
 );