fix(annotator): Cleanup managers on destroy (#616)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: Conrad Chan

src/document/DocumentAnnotator.ts

@@ -38,6 +38,10 @@ export default class DocumentAnnotator extends BaseAnnotator {
             this.highlightListener.destroy();
         }
 
+        if (this.managers) {
+            this.managers.forEach(managers => managers.forEach(manager => manager.destroy()));
+        }
+
         super.destroy();
     }
 

src/document/__tests__/DocumentAnnotator-test.ts

@@ -99,6 +99,18 @@ describe('DocumentAnnotator', () => {
             );
             expect(annotator.highlightListener?.destroy).toHaveBeenCalled();
         });
+
+        test('should destroy existing managers', () => {
+            annotator = getAnnotator();
+
+            const mockManager = ({ destroy: jest.fn() } as unknown) as BaseManager;
+            const mockManagersSet = new Set([mockManager]);
+            annotator.managers.set(1, mockManagersSet);
+
+            annotator.destroy();
+
+            expect(mockManager.destroy).toHaveBeenCalled();
+        });
     });
 
     describe('event handlers', () => {
@@ -235,7 +247,7 @@ describe('DocumentAnnotator', () => {
 
     describe('renderPage()', () => {
         test('should initialize a manager for a new page', () => {
-            const mockManager = ({ render: jest.fn() } as unknown) as BaseManager;
+            const mockManager = ({ destroy: jest.fn(), render: jest.fn() } as unknown) as BaseManager;
             const pageNumber = 1;
             const pageEl = getPage(pageNumber);
 

src/image/ImageAnnotator.ts

@@ -28,6 +28,10 @@ export default class ImageAnnotator extends BaseAnnotator {
             this.storeHandler();
         }
 
+        if (this.managers) {
+            this.managers.forEach(manager => manager.destroy());
+        }
+
         super.destroy();
     }
 

src/image/__tests__/ImageAnnotator-test.ts

@@ -75,6 +75,15 @@ describe('ImageAnnotator', () => {
 
             expect(annotator.storeHandler).toHaveBeenCalled();
         });
+
+        test('should destroy all managers', () => {
+            const mockManagersSet = new Set([mockManager]);
+            annotator.managers = mockManagersSet;
+
+            annotator.destroy();
+
+            expect(mockManager.destroy).toHaveBeenCalled();
+        });
     });
 
     describe('getManagers()', () => {