Fix: Mobile point annotation behavior#191
Merged
pramodsum merged 3 commits intobox:masterfrom May 24, 2018
Merged
Conversation
Contributor
pramodsum
commented
May 22, 2018
pramodsum
commented
- Attempting to create a point annotation on top of an existing point annotation will close the dialog.
- Initially only the point annotation icon would be removed but the dialog would remain with no way of closing it
- Attempting to create a point annotation on top of an existing point annotation will close the dialog. - Initially only the point annotation icon would be removed but the dialog would remain with no way of closing it
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
JustinHoldstock
approved these changes
May 22, 2018
Contributor
|
Tests? |
Contributor
Author
|
Yup will add some tests before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.