chore(typescript): Add support for typescript#399
Merged
jstoffan merged 1 commit intobox:masterfrom Mar 20, 2020
Merged
Conversation
jstoffan
commented
Mar 20, 2020
| @@ -0,0 +1 @@ | |||
| export default {}; | |||
Collaborator
Author
There was a problem hiding this comment.
This can be removed once we start adding actual Typescript files.
mingzexiao6
reviewed
Mar 20, 2020
| { | ||
| test: ['./src/**/*.ts', './src/**/*.tsx'], | ||
| presets: [ | ||
| [ |
Contributor
There was a problem hiding this comment.
Do we need @babel/preset-react here during the transition stage?
Collaborator
Author
There was a problem hiding this comment.
I don't think so, since it's already in the presets section. This is the overrides section for specific file types.
Contributor
There was a problem hiding this comment.
Yeah, but from what i understand, if you add @babel/preset-react, you can rename current react files to .ts and .tsx right now. It's useful during your transition stage.
Collaborator
Author
There was a problem hiding this comment.
Gotcha. I was really only looking at new files. If we find ourselves converting existing components, we should add it.
mickr
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.