feat(region): Add cursor tooltip#488
Merged
mergify[bot] merged 2 commits intobox:masterfrom May 20, 2020
Merged
Conversation
jstoffan
suggested changes
May 18, 2020
| placement: 'right', | ||
| }; | ||
|
|
||
| const generateGetBoundingClientRect = (x = 0, y = 0) => () => ({ |
Collaborator
There was a problem hiding this comment.
Does new DOMRect work for our purposes?
Contributor
Author
There was a problem hiding this comment.
DOMRect is not defined in test. It took me one hour to try mocking it but the new stuff is complicated. So I changed it back.
ConradJChan
reviewed
May 18, 2020
mingzexiao6
force-pushed
the
add-cursor-popup
branch
from
39c6aac to
f8e04cc
Compare
jstoffan
reviewed
May 19, 2020
mingzexiao6
force-pushed
the
add-cursor-popup
branch
from
f8e04cc to
7ef975b
Compare
jstoffan
reviewed
May 20, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
Can you add a screenshot?
jstoffan
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.