feat(highlights): Render staged highlight#553
Merged
ConradJChan merged 8 commits intobox:masterfrom Aug 18, 2020
Merged
Conversation
mingzexiao6
reviewed
Aug 12, 2020
mingzexiao6
reviewed
Aug 12, 2020
jstoffan
reviewed
Aug 12, 2020
added 2 commits
August 13, 2020 11:45
jstoffan
reviewed
Aug 17, 2020
| } | ||
| setMode(Mode.HIGHLIGHT); | ||
| setStatus(CreatorStatus.staged); | ||
| setStaged({ target: { location: { value: location, type: 'page' }, shapes, type: 'highlight' } }); |
Collaborator
There was a problem hiding this comment.
Most of this should be handled in something similar to createRegionAction.
jstoffan
reviewed
Aug 17, 2020
jstoffan
reviewed
Aug 17, 2020
jstoffan
reviewed
Aug 17, 2020
jstoffan
suggested changes
Aug 17, 2020
ConradJChan
force-pushed
the
render-staged-highlight
branch
from
a671478 to
8ba5802
Compare
jstoffan
reviewed
Aug 17, 2020
jstoffan
previously approved these changes
Aug 18, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
LGTM other than some minor cleanup
jstoffan
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Screenshot of rendering staged highlight
