feat(highlight): Render promoter tooltip#557
Conversation
| @@ -0,0 +1,94 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Do we have a convention for folder names? Seems like most folders are lowercased
There was a problem hiding this comment.
This is my bad. I used PascalCase for the component folder names due to old habit. They should be hyphenated lowercase, instead. Seems like something to change in a separate PR, though.
| const { x, y, height, width } = rect; | ||
|
|
||
| const reference = { | ||
| getBoundingClientRect: () => ({ |
There was a problem hiding this comment.
Was going to ask if you could use the DOMRect constructor but IE (https://developer.mozilla.org/en-US/docs/Web/API/DOMRect/DOMRect)
There was a problem hiding this comment.
Would this be worth a simple polyfill so we can use the constructor style? We use it in several places now, iirc.
There was a problem hiding this comment.
Sounds good. I will submit a separate PR to address this.
mingzexiao6
force-pushed
the
add-promoter
branch
2 times, most recently
from
874cd84 to
adbe203
Compare
| const { x, y, height, width } = rect; | ||
|
|
||
| const reference = { | ||
| getBoundingClientRect: () => ({ |
There was a problem hiding this comment.
Would this be worth a simple polyfill so we can use the constructor style? We use it in several places now, iirc.
mingzexiao6
force-pushed
the
add-promoter
branch
from
adbe203 to
1eac2ad
Compare
mingzexiao6
force-pushed
the
add-promoter
branch
from
05f2efe to
9af94a8
Compare
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
LGTM. Please make sure to regression test the existing region functionality, especially given the changes to popup arrows and the BUIE upgrade.
mingzexiao6
force-pushed
the
add-promoter
branch
from
9af94a8 to
e6cde9e
Compare
3 participants
No description provided.