feat(highlightlistener): Avoid get selection race#566
Merged
ConradJChan merged 1 commit intobox:masterfrom Aug 28, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you make a quick text selection, you sometimes find that the text selection goes beyond the text. This could also cause a slight shift in the highlight promoter popup after the selection is finished
What happens is that
isMouseSelectingis set to false onmouseupbut delays getting the text selection by 300ms -- meanwhile the debouncedselectionchangeevent fires after 500ms and sinceisMouseSelectingis already set to false, it proceeds to grab the text selection before PDFJS has time to finish the enhanced text layer work.