feat(eventing): Emit new annotations_staged_change event#570
Merged
ConradJChan merged 2 commits intobox:masterfrom Sep 8, 2020
Merged
feat(eventing): Emit new annotations_staged_change event#570ConradJChan merged 2 commits intobox:masterfrom
ConradJChan merged 2 commits intobox:masterfrom
Conversation
ConradJChan
force-pushed
the
staged-change-event
branch
from
3f3f513 to
c8e00f4
Compare
jstoffan
reviewed
Sep 1, 2020
jstoffan
reviewed
Sep 1, 2020
| [resetCreatorAction.toString()]: handleResetCreatorAction, | ||
| [setActiveAnnotationIdAction.toString()]: handleActiveAnnotationEvents, | ||
| [setIsInitialized.toString()]: handleAnnotationsInitialized, | ||
| [setStagedAction.toString()]: handleSetStagedAction, |
Collaborator
There was a problem hiding this comment.
Do we need to handle setStatusAction? Or can it even take the place of setStagedAction here?
Contributor
Author
There was a problem hiding this comment.
I think we should stick to setStagedAction since the transitions in state for staged allows us to infer the event status as well as the annotation type
jstoffan
reviewed
Sep 1, 2020
2 tasks
mingzexiao6
reviewed
Sep 8, 2020
Comment on lines
+18
to
+19
| if (prevStaged === null && nextStaged !== null) { | ||
| status = 'create'; | ||
| } | ||
|
|
||
| if (prevStaged !== null && nextStaged !== null) { | ||
| status = 'update'; | ||
| } |
Contributor
There was a problem hiding this comment.
Should we handle if (prevStaged !== null && nextStaged === null)? Maybe states is cancel?
Contributor
Author
There was a problem hiding this comment.
I left it off since our pattern of usage for cancel is to use resetCreatorAction.
ConradJChan
force-pushed
the
staged-change-event
branch
from
c8e00f4 to
c2c0e20
Compare
ConradJChan
force-pushed
the
staged-change-event
branch
from
c2c0e20 to
71220ef
Compare
jstoffan
approved these changes
Sep 8, 2020
mingzexiao6
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: