fix(popuplayer): Ensure the staged type matches the mode#605
Merged
mergify[bot] merged 2 commits intobox:masterfrom Sep 28, 2020
Merged
fix(popuplayer): Ensure the staged type matches the mode#605mergify[bot] merged 2 commits intobox:masterfrom
mergify[bot] merged 2 commits intobox:masterfrom
Conversation
jstoffan
approved these changes
Sep 28, 2020
Collaborator
jstoffan
left a comment
jstoffan
left a comment
There was a problem hiding this comment.
I just realized that the isCreatorStaged... methods aren't selectors, but are util methods and are used elsewhere in the class, as well. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the issue where toggling between annotation modes doesn't hide the
PopupReply