refactor(resin): Move iscurrent and fileid to BaseManager#642
Merged
ConradJChan merged 5 commits intobox:masterfrom Dec 2, 2020
Merged
refactor(resin): Move iscurrent and fileid to BaseManager#642ConradJChan merged 5 commits intobox:masterfrom
ConradJChan merged 5 commits intobox:masterfrom
Conversation
jstoffan
reviewed
Dec 1, 2020
ConradJChan
force-pushed
the
move-resin-tag
branch
from
2567da4 to
94ca469
Compare
ConradJChan
force-pushed
the
move-resin-tag
branch
from
94ca469 to
4730b40
Compare
ConradJChan
changed the title
Contributor
|
You need to change the first commit message in order to change the merged commit title. Changing the PR title doesn't work. |
mingzexiao6
previously approved these changes
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
| } | ||
|
|
||
| getManagers(parentEl: HTMLElement, referenceEl: HTMLElement): Set<Manager> { | ||
| const isCurrentFileVersion = getIsCurrentFileVersion(this.store.getState()); |
Collaborator
There was a problem hiding this comment.
Does this all work correctly if these store values change outside of the getManagers flow? Should we introduce something like the BaseManager style method that gets called when these values change in the store?
Contributor
Author
There was a problem hiding this comment.
I think that's unnecessary at this point. If the fileid or iscurrent properties change, a new preview is triggered and annotations is reinstantiated. If at a later point we introduce a field that can change on the fly here then we'd need to solve that problem
mingzexiao6
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
reviewed
Dec 2, 2020
jstoffan
previously approved these changes
Dec 2, 2020
jstoffan
approved these changes
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since resin tags are picked up based on DOM hierarchy, this change moves them into the
BaseManagerwhich is the highest DOM element that Annotations controls.TODO: