feat(drawing): Support drawing colors#653
Merged
mergify[bot] merged 2 commits intobox:masterfrom Dec 17, 2020
Merged
Conversation
ConradJChan
reviewed
Dec 15, 2020
ConradJChan
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
ChenCodes
reviewed
Dec 15, 2020
jstoffan
reviewed
Dec 15, 2020
jstoffan
reviewed
Dec 15, 2020
mingzexiao6
force-pushed
the
drawing-color
branch
from
1529a51 to
4a93681
Compare
jstoffan
reviewed
Dec 16, 2020
ConradJChan
reviewed
Dec 16, 2020
mingzexiao6
force-pushed
the
drawing-color
branch
from
9054207 to
4d2644b
Compare
jstoffan
reviewed
Dec 16, 2020
| <DrawingCreator className="ba-DrawingAnnotations-creator" onStart={handleStart} onStop={handleStop} /> | ||
| <DrawingCreator | ||
| className="ba-DrawingAnnotations-creator" | ||
| color={color} |
Collaborator
There was a problem hiding this comment.
Could also use the useSelector hook inside DrawingCreator to avoid having to pass this down.
Contributor
Author
There was a problem hiding this comment.
Stroke has two properties, color and size. Using useSelector for color and default value for size seems not consistent. Maybe we can refactor it if we add size to the store in the future.
ConradJChan
reviewed
Dec 17, 2020
ConradJChan
previously approved these changes
Dec 17, 2020
mingzexiao6
force-pushed
the
drawing-color
branch
from
b855377 to
aef4627
Compare
ConradJChan
approved these changes
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview PR: box/box-content-preview#1309