fix(drawing): apply blur to smaller drawn annotations#665
Merged
ChenCodes merged 2 commits intobox:masterfrom Jan 13, 2021
Merged
fix(drawing): apply blur to smaller drawn annotations#665ChenCodes merged 2 commits intobox:masterfrom
ChenCodes merged 2 commits intobox:masterfrom
Conversation
mingzexiao6
reviewed
Jan 13, 2021
Contributor
mingzexiao6
left a comment
mingzexiao6
left a comment
There was a problem hiding this comment.
Don't forget to do cross-browser testing.
Collaborator
|
The commit message should try to describe what was fixed rather than what code was changed. |
ChenCodes
changed the title
jstoffan
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Issue:
We were seeing a bug where because we were using
primitiveUnits="objectBoundingBox", this was causing the annotated elements that were smaller to not have a prominent blur applied. Removing the primitiveUnits attribute + making the opacity darker helped solve this issue.Demo:
Chrome
Safari
Firefox
Edge
IE11
