fix(drawing): fix blur not visible for drawn annotation in Safari#675
Merged
ChenCodes merged 12 commits intobox:masterfrom Jan 22, 2021
Merged
Conversation
ConradJChan
reviewed
Jan 21, 2021
ConradJChan
reviewed
Jan 21, 2021
jstoffan
reviewed
Jan 21, 2021
jstoffan
reviewed
Jan 21, 2021
jstoffan
reviewed
Jan 21, 2021
jstoffan
approved these changes
Jan 22, 2021
ConradJChan
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Issue:
In Safari, we noticed that newly drawn annotations were not receiving a blur effect from the filter element in the SVG on hover.
After closer inspection, it looks like we were using a common identifier for the element in DrawingSVG. Safari actually did the right thing in displaying the UI bug as using a common identifier for different elements should result in a buggy experience.
Here is the article that talked about a similar issue for what we were experiencing: https://css-tricks.com/heres-how-i-solved-a-weird-bug-using-tried-and-true-debugging-strategies/
Solution:
The solution is to assign a unique identifier to each instance of a filter that is being used.
Demo:
