Skip to content

feat(annotator): Add public query methods to BaseAnnotator#736

Merged
jackiejou merged 1 commit intobox:masterfrom
jackiejou:annotation-escape
Mar 11, 2026
Merged

feat(annotator): Add public query methods to BaseAnnotator#736
jackiejou merged 1 commit intobox:masterfrom
jackiejou:annotation-escape

Conversation

@jackiejou
Copy link
Collaborator

Summary

  • Add getActiveId(), getAnnotationContainerEl(), and isPopupOpen() public methods to BaseAnnotator
  • These methods expose annotation state needed by Preview SDK for escape key handling
  • Add comprehensive unit tests for all three new methods

Test Plan

  • All 463 existing tests pass
  • 7 new unit tests added covering all code paths
  • Lint and type checks pass
  • Build succeeds

Add getActiveId, getAnnotationContainerEl, and isPopupOpen methods
to support annotation escape key handling from Preview SDK.
@jackiejou jackiejou marked this pull request as ready for review March 11, 2026 00:56
@jackiejou jackiejou requested a review from a team as a code owner March 11, 2026 00:56
@jackiejou jackiejou merged commit cc57fa3 into box:master Mar 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants