fix(document): apply rotation transform to document annotation layers#744
Merged
kduncanhsu merged 1 commit intobox:masterfrom May 5, 2026
Conversation
Mirror the ImageAnnotator pattern by applying rotation transforms to annotation layers in DocumentAnnotator.renderPage(). When rotation is non-zero, layers are sized to original (unrotated) page dimensions, centered, and rotated to stay anchored to the rotated page content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Duncan Hsu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jmcbgaston
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DocumentAnnotator.renderPage(), mirroring the ImageAnnotator patterntranslate(-50%, -50%), and rotated to stay anchored to the rotated page contentCompanion PR
rotationAnglein scale events so the rotation state reaches the annotations store (Link: fix(doc): improve PDF rotation behavior for annotations box-content-preview#1638)Test plan