Skip to content

feat(popup): Show resolved state and user avatars in thread#745

Merged
jackiejou merged 3 commits intobox:masterfrom
jackiejou:feat/threaded-annotations-v2-resolved-state
May 5, 2026
Merged

feat(popup): Show resolved state and user avatars in thread#745
jackiejou merged 3 commits intobox:masterfrom
jackiejou:feat/threaded-annotations-v2-resolved-state

Conversation

@jackiejou
Copy link
Copy Markdown
Collaborator

@jackiejou jackiejou commented May 5, 2026

Summary

  • Render the resolved banner in PopupV2 (checkmark + "Resolved by {user} at {time}") using the annotation's status field, matching how box-ui-elements activity-feed-v2 presents resolved threads.
  • Build avatar URLs from the file's apiHost and token so thread messages and the mention dropdown both show user avatars.

Test Plan

  • Open a thread on a resolved annotation and verify the banner renders with attribution and timestamp.
  • Open a thread and confirm each message shows the author's avatar.
  • In the reply editor, type @ and confirm avatars appear next to each suggested user.
  • Tab through the popup and confirm focus stays inside; close it and confirm focus returns to the triggering element.
  • Existing v1 popup flows still render correctly when the threaded-annotations feature is off.

@jackiejou jackiejou marked this pull request as ready for review May 5, 2026 00:15
@jackiejou jackiejou requested a review from a team as a code owner May 5, 2026 00:15
Comment thread src/components/Popups/PopupV2.tsx Outdated
Fetch user avatars via an Authorization header and render them from
blob URLs, so the access token is no longer appended to the avatar URL
as a query parameter. Blob URLs are cached and revoked on unmount or
when credentials change. In-flight requests compare captured credentials
against the current ref so a token swap cannot land a stale blob in the
cache.
@jackiejou jackiejou merged commit 1d8ecb8 into box:master May 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants