Update docs around saving/restoring proxy settings #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configured proxies aren't saved or restored with BoxAPIConnection#save() or BoxAPIConnection#restore(String). This is intentional because: 1. We don't have a clean way of serializing the Proxy object to JSON. 2. If the proxy has a password, it would be unsafe to persist it to the saved state string. This change updates the javadocs so it's clear that proxy settings must be manually reconfigured after restoring an API connection. Fixes box#143.
|
Verified that @gcurtis has signed the CLA. Thanks for the pull request! |
gcurtis
added a commit
that referenced
this pull request
Jul 13, 2015
Update docs around saving/restoring proxy settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configured proxies aren't saved or restored with
BoxAPIConnection#save() or BoxAPIConnection#restore(String). This is
intentional because:
saved state string.
This change updates the javadocs so it's clear that proxy settings must
be manually reconfigured after restoring an API connection.
Fixes #143.