Skip to content

feat: Disable OkHttp auto retries on connection failure (box/box-codegen#874) #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

feat: Disable OkHttp auto retries on connection failure (box/box-codegen#874) #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9eed5f
chore: Update `.codegen.json` with commit hash of `codegen` and `open…
box-sdk-build Oct 28, 2025
e9739d9
feat: Disable OkHttp auto retries on connection failure (box/box-code…
box-sdk-build Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codegen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "engineHash": "4421f42", "specHash": "1715587", "version": "10.1.0" }
{ "engineHash": "e6b1577", "specHash": "1715587", "version": "10.1.0" }
15 changes: 9 additions & 6 deletions src/main/java/com/box/sdkgen/networking/boxnetworkclient/BoxNetworkClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,7 @@ public BoxNetworkClient(OkHttpClient httpClient) {
}

public BoxNetworkClient() {
OkHttpClient.Builder builder =
new OkHttpClient.Builder()
.followSslRedirects(true)
.followRedirects(false)
.connectionSpecs(singletonList(MODERN_TLS));
httpClient = builder.build();
httpClient = getDefaultOkHttpClientBuilder().build();
}

public OkHttpClient getHttpClient() {
Expand Down Expand Up @@ -390,4 +385,12 @@ public void writeTo(BufferedSink sink) throws IOException {
}
};
}

public static OkHttpClient.Builder getDefaultOkHttpClientBuilder() {
return new OkHttpClient.Builder()
.followSslRedirects(true)
.followRedirects(false)
.connectionSpecs(singletonList(MODERN_TLS))
.retryOnConnectionFailure(false);
}
}
15 changes: 9 additions & 6 deletions src/main/java/com/box/sdkgen/networking/defaultnetworkclient/DefaultNetworkClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,7 @@ public DefaultNetworkClient(OkHttpClient httpClient) {
}

public DefaultNetworkClient() {
OkHttpClient.Builder builder =
new OkHttpClient.Builder()
.followSslRedirects(true)
.followRedirects(false)
.connectionSpecs(singletonList(MODERN_TLS));
httpClient = builder.build();
httpClient = getDefaultOkHttpClientBuilder().build();
}

public FetchResponse fetch(FetchOptions options) {
Expand Down Expand Up @@ -283,6 +278,14 @@ public void writeTo(BufferedSink sink) throws IOException {
};
}

public static OkHttpClient.Builder getDefaultOkHttpClientBuilder() {
return new OkHttpClient.Builder()
.followSslRedirects(true)
.followRedirects(false)
.connectionSpecs(singletonList(MODERN_TLS))
.retryOnConnectionFailure(false);
}

private static void throwOnUnsuccessfulResponse(
Request request, FetchResponse fetchResponse, Exception exceptionThrown) {
if (fetchResponse == null) {
Expand Down