Skip to content

redirected create legal hold policy method call #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2018
Merged

redirected create legal hold policy method call #654

merged 3 commits into from
Nov 2, 2018

Conversation

@carycheng
Copy link

@carycheng carycheng commented Nov 2, 2018

No description provided.

@carycheng carycheng requested a review from mattwiller November 2, 2018 19:32
@boxcla
Copy link

boxcla commented Nov 2, 2018

Hi @carycheng, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@coveralls
Copy link

coveralls commented Nov 2, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1758

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 58.733%
Totals Coverage Status
Change from base Build 1755: 0.08%
Covered Lines: 4600
Relevant Lines: 7832
💛 - Coveralls

mattwiller
mattwiller approved these changes Nov 2, 2018
View reviewed changes
doc/legal_holds.md
```

If you wish to create an ongoing Legal Hold Policy with no end date, call [`createOngoing(BoxAPIConnection api, String name, String description)`][create-ongoing].
If you wish to create an ongoing Legal Hold Policy with no end date and a description, call [`createOngoing(BoxAPIConnection api, String name, String description)`][create-ongoing].
Copy link

@mattwiller mattwiller Nov 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just document this version; they can always just pass null for the description.

@carycheng carycheng merged commit a7b8830 into master Nov 2, 2018
@carycheng carycheng deleted the legal_hold_policies_create_patch branch November 2, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mattwiller mattwiller mattwiller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@carycheng @boxcla @coveralls @mattwiller