Skip to content

Allow per-connection timeouts #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2018
Merged

Allow per-connection timeouts #660

merged 1 commit into from
Nov 15, 2018

Conversation

@mattwiller
Copy link

@mattwiller mattwiller commented Nov 15, 2018

Fixes #659

@mattwiller mattwiller requested a review from carycheng November 15, 2018 01:22
@boxcla
Copy link

boxcla commented Nov 15, 2018

Verified that @mattwiller has signed the CLA. Thanks for the pull request!

@coveralls
Copy link

coveralls commented Nov 15, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1765

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 58.823%
Totals Coverage Status
Change from base Build 1764: 0.07%
Covered Lines: 4617
Relevant Lines: 7849
💛 - Coveralls

@mattwiller mattwiller merged commit 665ffd1 into master Nov 15, 2018
@mattwiller mattwiller deleted the local_timeouts branch November 15, 2018 20:48
nddipiazza
nddipiazza reviewed Nov 16, 2018
View reviewed changes
src/test/java/com/box/sdk/BoxAPIConnectionTest.java

BoxAPIConnection api = new BoxAPIConnection("");

api.setConnectTimeout(instanceConnectTimeout);
Copy link

@nddipiazza nddipiazza Nov 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nddipiazza nddipiazza nddipiazza left review comments

@carycheng carycheng carycheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mattwiller @boxcla @coveralls @nddipiazza @carycheng