added tests and implementation for options object #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @carycheng, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks! |
Pull Request Test Coverage Report for Build 1777
💛 - Coveralls |
mattwiller
reviewed
Nov 15, 2018
| /** | ||
| * @see #getOptionsObject() | ||
| */ | ||
| private List<Option> optionsObject; |
There was a problem hiding this comment.
Is the options property being used anywhere now? If not, you could just change its type and not have two properties for this.
| * Gets list of possible options for options type of the field. | ||
| * @return list of possible options for option type of the field. | ||
| */ | ||
| public List<Option> getOptionsObject() { |
There was a problem hiding this comment.
This method name should be pluralized, e.g. getOptionsObjects()
added 6 commits
November 15, 2018 13:25
…va-sdk into metadata-template-bug
mattwiller
reviewed
Nov 16, 2018
| */ | ||
| public void setOptions(List<String> options) { | ||
| this.options = options; | ||
| JsonObject optionObject = new JsonObject(); |
There was a problem hiding this comment.
Is there any issue with re-using the same JsonObject for each key here?
| @Category(IntegrationTest.class) | ||
| public void createMetadataTemplateSucceeds() { | ||
| BoxAPIConnection api = new BoxAPIConnection(TestConfig.getAccessToken()); | ||
| BoxAPIConnection api = new BoxAPIConnection("UXu8HsUlB4K5uDWGWSO075k1qq9hle93"); |
| MetadataTemplate template = MetadataTemplate.createMetadataTemplate(api, "enterprise", | ||
| "documentFlow03", "Document Flow 03", false, fields); | ||
| } catch (BoxAPIException apiEx) { | ||
| System.out.println("Exception: " + apiEx); |
mattwiller
approved these changes
Nov 16, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.