Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/groups.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ To update a group, call [`updateInfo(BoxGroup.Info fieldsToUpdate)`][update-grou
```java
BoxGroup group = new BoxGroup(api, id);
BoxGroup.Info groupInfo = group.getInfo();
groupInfo.addPendingChange("name", "New name for My Group");
groupInfo.setName("New name for My Group");
group.updateInfo(groupInfo);
```

Expand Down Expand Up @@ -165,7 +165,7 @@ A groups membership can be updated by calling the
```java
BoxGroupMembership membership = new BoxGroupMembership(api, id);
BoxGroupMembership.Info info = membership.new Info();
info.addPendingChange("role", role);
info.setRole(BoxGroupMembership.Role.MEMBER);
membership.updateInfo(info);
```

Expand Down
2 changes: 1 addition & 1 deletion doc/weblinks.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ A web link can be updated by calling the
```java
BoxWebLink webLink = new BoxWebLink(api, id);
BoxWebLink.Info webLinkInfo = webLink.new Info();
webLinkInfo.addPendingChange("name", "new name for weblink");
webLinkInfo.setName("new name for weblink");
webLink.updateInfo(webLinkInfo);
```

Expand Down
8 changes: 4 additions & 4 deletions src/test/java/com/box/sdk/BoxGroupMembershipTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ public class BoxGroupMembershipTest {
@Test
@Category(UnitTest.class)
public void testUpdateInfoSendsCorrectJson() {
final String role = "submaster";
final Role role = Role.SUBMASTER;

BoxAPIConnection api = new BoxAPIConnection("");
api.setRequestInterceptor(new JSONRequestInterceptor() {
@Override
protected BoxAPIResponse onJSONRequest(BoxJSONRequest request, JsonObject json) {
Assert.assertEquals("https://api.box.com/2.0/group_memberships/0", request.getUrl().toString());
Assert.assertEquals(role, json.get("role").asString());
Assert.assertEquals(role.toJSONString(), json.get("role").asString());
return new BoxJSONResponse() {
@Override
public String getJSON() {
Expand All @@ -54,7 +54,7 @@ public String getJSON() {

BoxGroupMembership membership = new BoxGroupMembership(api, "0");
BoxGroupMembership.Info info = membership.new Info();
info.addPendingChange("role", role);
info.setRole(role);
membership.updateInfo(info);
}

Expand Down Expand Up @@ -97,7 +97,7 @@ public void testUpdateInfoParseAllFieldsCorrectly() throws ParseException {
api.setRequestInterceptor(JSONRequestInterceptor.respondWith(fakeJSONResponse));
BoxGroupMembership membership = new BoxGroupMembership(api, id);
BoxGroupMembership.Info info = membership.new Info();
info.addPendingChange("role", "non-empty");
info.setRole(Role.SUBMASTER);
membership.updateInfo(info);
Assert.assertEquals(id, info.getID());
Assert.assertEquals(userID, info.getUser().getID());
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/box/sdk/BoxGroupTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ public void testUpdateAGroupInfoSendsCorrectJson() throws IOException {

BoxGroup group = new BoxGroup(this.api, groupID);
BoxGroup.Info groupInfo = group.getInfo();
groupInfo.addPendingChange("name", groupName);
groupInfo.setName(groupName);
group.updateInfo(groupInfo);
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/box/sdk/BoxWebLinkTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ public void testUpdateWebLinkSucceedsAndSendsCorrectJson() throws IOException {

BoxWebLink webLink = new BoxWebLink(this.api, webLinkID);
BoxWebLink.Info webLinkInfo = webLink.new Info();
webLinkInfo.addPendingChange("name", newName);
webLinkInfo.setName(newName);
webLinkInfo.addPendingChange("url", newURL);
webLink.updateInfo(webLinkInfo);

Expand Down