Skip to content

Fix bug when thumbnail representations are not found#597

Merged
swfree merged 1 commit into
box:mainfrom
DaveSawyer:index_error
May 3, 2021
Merged

Fix bug when thumbnail representations are not found#597
swfree merged 1 commit into
box:mainfrom
DaveSawyer:index_error

Conversation

@DaveSawyer
Copy link
Copy Markdown
Contributor

@DaveSawyer DaveSawyer commented May 1, 2021

Also update a comment. This can happen if the dimensions aren't found or if the file is very old and the representations have been removed. Fixes issue #596.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 1, 2021

CLA assistant check
All committers have signed the CLA.

@DaveSawyer DaveSawyer changed the title issue #596: Return 0 bytes is no representation found issue #596: Return 0 bytes if no representation found May 1, 2021
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2554

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 96.971%

Totals Coverage Status
Change from base Build 2553: 0.002%
Covered Lines: 3073
Relevant Lines: 3169

💛 - Coveralls

@sujaygarlanka sujaygarlanka changed the title issue #596: Return 0 bytes if no representation found Return 0 bytes if no representation found May 3, 2021
@sujaygarlanka sujaygarlanka changed the title Return 0 bytes if no representation found Fix bug when thumbnail representations are not found May 3, 2021
@swfree swfree merged commit 4f5e4c3 into box:main May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants