APICallWrapper.__get__ must return a bound method #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This magic method was previously returning a plain, unbound function. This tricks some introspection code, which expects it to be a bound method. Also add unit test coverage for that module. Bump version to 2.0.0a6.
|
Verified that @jmoldow has signed the CLA. Thanks for the pull request! |
Jeff-Meadows
approved these changes
Jul 27, 2017
|
|
||
| def test_api_call_decorated_method_must_be_a_cloneable_method(): | ||
|
|
||
| class Cls(object): |
Contributor
There was a problem hiding this comment.
could call this NonCloneable instead of Cls
| def test_api_call_decorated_method_delegates_to_wrapped_method(mock_cloneable, api_call_result): | ||
| args = (1, 2, 'ƒøø', 'bar') | ||
| kwargs = {'bar': 'ƒøø'} | ||
| assert mock_cloneable.api_call_method(*args, **kwargs) == (mock_cloneable, args, kwargs, api_call_result) |
Contributor
There was a problem hiding this comment.
you could take the api_call_method fixture, and call it instead of encoding here the functionality of the method
assert mock_cloneable.api_call_method(*args, **kwargs) == api_call_method(mock_cloneable, *args, **kwargs)
Contributor
Author
There was a problem hiding this comment.
I would prefer to leave this as-is.
If I do what you suggest, then we'll be passing through @api_call on both the LHS and RHS of the equality.
I could expose a fixture for the unbound method, but I'd rather not do that. I think it's fine as-is.
| args = (1, 2, 'ƒøø', 'bar') | ||
| kwargs = {'bar': 'ƒøø'} | ||
| api_call_method = cloneable_subclass_with_api_call_method.api_call_method | ||
| assert api_call_method(mock_cloneable, *args, **kwargs) == (mock_cloneable, args, kwargs, api_call_result) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This magic method was previously returning a plain, unbound
function. This tricks some introspection code, which expects it
to be a bound method.
Also add unit test coverage for that module.
Bump version to 2.0.0a6.