Fix the build for python 2.6 and python 3.3. #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of pytest (3.3.0) dropped support for these python versions, so we need to install an older version when we're being run on one of them.
|
Verified that @Jeff-Meadows has signed the CLA. Thanks for the pull request! |
Contributor
|
More and more tools are going to be dropping 2.6 support in the future (e.g. pip). At some point we should consider whether we should also drop 2.6 support. Rather than having conditional Python code inside setup.py, I feel like it would've been better to either:
|
mattwiller
pushed a commit
that referenced
this pull request
Jun 28, 2018
The latest version of pytest (3.3.0) dropped support for these python versions, so we need to install an older version when we're being run on one of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of pytest (3.3.0) dropped support for these
python versions, so we need to install an older version when
we're being run on one of them.