Updated make_request per iss261 #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jpan-box has signed the CLA. Thanks for the pull request! |
Contributor
Author
|
Fixed formatting errors. Should be correct now. |
anthonywee
reviewed
Mar 27, 2018
README.rst
Outdated
| body = json.dumps({"is_accepted":true}) | ||
| # Pass body as "data" argument | ||
| data = body |
Contributor
There was a problem hiding this comment.
Why do we set data = body here?
Contributor
There was a problem hiding this comment.
@anthonywee That seems to be what make_request needs to make passing data as body work properly. One of the most recent messages in our internal slack channel for the Python SDK refers to setting data = body, or data = whatever object contains the jsonified data. Maybe there's a better way to communicate that?
Contributor
Author
There was a problem hiding this comment.
sorry, that's my personal ^ account. This is from my actual box github account.
Contributor
Author
|
Duplicated by #265 , closing due to merge issues with 1.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261