-
Notifications
You must be signed in to change notification settings - Fork 220
Metadata template endpoints #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1b8d23a
WIP: Add metadata template endpoints
d0ae639
Merge branch 'master' of github.com:box/box-python-sdk into metadata_…
7792591
Finish metadata template endpoints implementation
d2d96ec
Add tests for metadata template endpoints
54a8e66
Fix lint errors
7f83a3f
Add documentation
4633ccf
Document paging params
40e4fbe
Add scope and template_key properties
f6c4e83
Add table of contents to docs
5eb4453
Allow object classes to exclude fields from translation
519f060
Fixes from code review feedback
3d88adb
Fixes from code review
4e208a9
Fix metadata template object ID kludge
44928c4
Merge branch 'master' into metadata_template_endpoints
dec4a0b
Fix code review comments
1f96206
Merge branch 'master' into metadata_template_endpoints
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal taste, I feel like
scopeshould come before the other optional parameters.scopeis logically the most important part of this operation. And in the APIs, scope always proceeds templateKey.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind moving it, but I put it last since at this time only enterprise scope templates can be created. Nobody calling this method today (and likely for the near future) will be setting that parameter, whereas they will likely want to set the others.