Improved the LRUCache class and added dostrings #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead of returning '-1', which can be the actual value being stored, raises :class:`KeyError` when key doesn't exist in cache. * Added docstrings for :class:`LRUCache`
boxsdk/util/lru_cache.py
Outdated
|
Can we use an existing library for LRU cache instead of rolling our own? Example, https://pypi.python.org/pypi/pylru/, https://pypi.python.org/pypi/cachetools/. |
Contributor
Author
|
@kunalparmar We can do that in a separate commit. |
Jeff-Meadows
added a commit
that referenced
this pull request
Feb 10, 2015
Improved the LRUCache class and added dostrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's wrong to return any value if the key doesn't exist in the cache since there's no good way to differentiate it from the actual value stored in cache.