Skip to content

Fix Travis CI for Python 2 and Pylint #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2021
Merged

Fix Travis CI for Python 2 and Pylint #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67b24e9
Fix unit test for python<3.6
mwwoda Jul 5, 2021
639f78f
change virtualenv version
mwwoda Jul 5, 2021
5a59b41
switch to virtualenv
mwwoda Jul 5, 2021
b947b29
add python version for pypy
mwwoda Jul 5, 2021
396f6c6
remove python version check
mwwoda Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boxsdk/object/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ def get_thumbnail_representation(self, dimensions, extension='png'):
"""
rep_hints = '[{0}?dimensions={1}]'.format(extension, dimensions)
representation = self.get_representation_info(rep_hints)
if len(representation):
if representation:
url = representation[0]['content']['url_template']
url = url.replace('{+asset_path}', '')
response = self._session.get(url, expect_json_response=False)
Expand Down
2 changes: 1 addition & 1 deletion test/unit/object/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,4 +901,4 @@ def test_get_thumbnail_representation_not_found(
headers={'X-Rep-Hints': '[{}?dimensions={}]'.format(extension, dimensions)},
params={'fields': 'representations'},
)
assert b'' == thumb
assert thumb == b''
6 changes: 5 additions & 1 deletion test/unit/object/test_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import json

from mock import ANY

import pytest

from boxsdk.config import API
Expand Down Expand Up @@ -375,7 +377,9 @@ def test_metadata_query(
)
item1 = items.next()
item2 = items.next()
mock_box_session.post.assert_called_once_with(expected_url, data=json.dumps(expected_data), headers=expected_headers)
mock_box_session.post.assert_called_once_with(expected_url, data=ANY, headers=expected_headers)
assert dict(json.loads(mock_box_session.post.call_args[1]['data'])) == expected_data
assert mock_box_session.post.call_args[1]['headers'] == expected_headers
assert item1['type'] == 'file'
assert item1['metadata']['enterprise_67890']['catalogImages']['$parent'] == 'file_50347290'
assert item2['type'] == 'folder'
Expand Down