-
Notifications
You must be signed in to change notification settings - Fork 219
Add network and auth subclasses. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-Adds LoggingNetwork to allow clients to see what network calls the SDK is making. -Adds RemoteOAuth2 to allow auth to occur in a different process or machine from the SDK. -Adds RedisManagedOAuth2 to allow token storage in Redis, to enable multiple processes or machines to share tokens.
|
Verified that @Jeff-Meadows has signed the CLA. Thanks for the pull request! |
|
Obviously this needs tests, but wanted to review the ideas first and see if we should introduce these classes into the SDK. |
boxsdk/auth/redis_managed_oauth2.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. I refactored the base class to make _store_tokens overridable to avoid overriding this, but then forgot to change it.
Add a new coop auth demo.
|
|
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The callable might not be able to retrieve anything (e.g., the cache might not have this user yet). Should we allow the callable to return None, or allow the tuple elements to be None?
Add network and auth subclasses.
CooperativelyManagedOAuth2Mixinclass.