Skip to content

Conversation

@Jeff-Meadows
Copy link
Contributor

  • Adds LoggingNetwork to allow clients to see what network calls the SDK is making.
  • Adds RemoteOAuth2 to allow auth to occur in a different process or machine from the SDK.
  • Adds RedisManagedOAuth2 to allow token storage in Redis, to enable multiple processes or machines to share tokens.
  • Addresses issue Token Refresh in a Multiple Process Environment #71 with CooperativelyManagedOAuth2Mixin class.

-Adds LoggingNetwork to allow clients to see what network calls the SDK is making.
-Adds RemoteOAuth2 to allow auth to occur in a different process or machine from the SDK.
-Adds RedisManagedOAuth2 to allow token storage in Redis, to enable multiple processes or machines to share tokens.
@boxcla
Copy link

boxcla commented Oct 14, 2015

Verified that @Jeff-Meadows has signed the CLA. Thanks for the pull request!

@Jeff-Meadows
Copy link
Contributor Author

Obviously this needs tests, but wanted to review the ideas first and see if we should introduce these classes into the SDK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I refactored the base class to make _store_tokens overridable to avoid overriding this, but then forgot to change it.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 2bb05e3 on box:auth into 51a8a47 on box:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.54% when pulling b35881f on auth into 51a8a47 on master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.53% when pulling 97a7774 on auth into b661d7e on master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.53% when pulling 3fff540 on auth into b661d7e on master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callable might not be able to retrieve anything (e.g., the cache might not have this user yet). Should we allow the callable to return None, or allow the tuple elements to be None?

Jeff-Meadows added a commit that referenced this pull request Nov 5, 2015
Add network and auth subclasses.
@Jeff-Meadows Jeff-Meadows merged commit 0fd40a6 into master Nov 5, 2015
@Jeff-Meadows Jeff-Meadows deleted the auth branch November 5, 2015 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants