Fix: min height button overlapping issue with the elements (#28)

priyajeet · web-flow · commit 0d4759c92f18 · 2017-07-17T18:19:12.000-07:00
diff --git a/src/components/ContentExplorer/Content.scss b/src/components/ContentExplorer/Content.scss
@@ -2,7 +2,7 @@
 
 .bce-content {
     display: flex;
-    flex: 1;
+    flex: 1 0 230px;
     flex-direction: column;
     position: relative;
 }
diff --git a/src/components/ContentExplorer/ItemList.scss b/src/components/ContentExplorer/ItemList.scss
@@ -2,7 +2,6 @@
 
 .bce-item-grid {
     flex: 1;
-    min-height: 300px;
 
     // sass-lint:disable class-name-format
     .ReactVirtualized__Table__Grid {
diff --git a/src/components/ContentPicker/Content.scss b/src/components/ContentPicker/Content.scss
@@ -2,7 +2,7 @@
 
 .bcp-content {
     display: flex;
-    flex: 1;
+    flex: 1 0 160px;
     flex-direction: column;
     position: relative;
 }
diff --git a/src/components/ContentPicker/ItemList.scss b/src/components/ContentPicker/ItemList.scss
@@ -2,7 +2,6 @@
 
 .bcp-item-grid {
     flex: 1;
-    min-height: 300px;
 
     // sass-lint:disable class-name-format
     .ReactVirtualized__Table__Grid {
diff --git a/src/components/ContentTree/Content.scss b/src/components/ContentTree/Content.scss
@@ -2,12 +2,11 @@
 
 .bct-content {
     display: flex;
-    flex: 1;
+    flex: 1 0 350px;
     flex-direction: column;
 
     .bct-item-list {
         flex: 1;
-        min-height: 300px;
         position: relative;
 
         // sass-lint:disable class-name-format
diff --git a/src/components/ContentUploader/DroppableContent.scss b/src/components/ContentUploader/DroppableContent.scss
@@ -1,12 +1,11 @@
 .bcu-droppable-content {
     display: flex;
-    flex: 1;
+    flex: 1 0 200px;
     flex-direction: column;
     position: relative;
 
     .bcu-item-list {
         flex: 1;
-        min-height: 300px;
         position: relative;
 
         // sass-lint:disable class-name-format
diff --git a/src/components/ContentUploader/UploadState.scss b/src/components/ContentUploader/UploadState.scss
@@ -5,7 +5,6 @@
     display: flex;
     flex: 1;
     justify-content: center;
-    min-height: 300px;
     position: relative;
     text-align: center;
 
diff --git a/src/components/EmptyState/EmptyState.scss b/src/components/EmptyState/EmptyState.scss
@@ -4,5 +4,4 @@
     flex: 1;
     flex-direction: column;
     justify-content: center;
-    min-height: 300px;
 }
diff --git a/src/components/Header/Header.scss b/src/components/Header/Header.scss
@@ -5,7 +5,7 @@
     background: $almost-white;
     border-bottom: 1px solid $off-white;
     display: flex;
-    height: 70px;
+    flex: 0 0 70px;
     justify-content: space-between;
     padding: 0 25px 0 0;
 
diff --git a/src/components/SubHeader/Sort.scss b/src/components/SubHeader/Sort.scss
@@ -6,7 +6,7 @@
     display: flex;
 }
 
-.buik-sort-btn {
+.buik-btn.buik-sort-btn {
     padding: 5px 16px;
 
     .bce:not(.buik-is-small) & {
diff --git a/src/components/SubHeader/SubHeader.scss b/src/components/SubHeader/SubHeader.scss
@@ -5,7 +5,7 @@
     border-bottom: 1px solid $off-white;
     box-shadow: 0 4px 6px -2px $transparent-black;
     display: flex;
-    height: 50px;
+    flex: 0 0 50px;
     justify-content: space-between;
     padding: 0 25px;
 
diff --git a/src/components/base.scss b/src/components/base.scss
@@ -12,6 +12,7 @@
     height: 100%;
     letter-spacing: .13px;
     margin: 0;
+    min-width: 350px;
     outline: none;
     overflow: hidden;
     padding: 0;
diff --git a/test/explorer-no-react.html b/test/explorer-no-react.html
@@ -18,7 +18,6 @@
 
             .explorer1 {
                 width: 100%;
-                height: 600px;
                 overflow: auto;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`.bce-content {`
`4`	`4`	`display: flex;`
`5`		`- flex: 1;`
	`5`	`+ flex: 1 0 230px;`
`6`	`6`	`flex-direction: column;`
`7`	`7`	`position: relative;`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`.bcp-content {`
`4`	`4`	`display: flex;`
`5`		`- flex: 1;`
	`5`	`+ flex: 1 0 160px;`
`6`	`6`	`flex-direction: column;`
`7`	`7`	`position: relative;`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,4 @@`
`4`	`4`	`flex: 1;`
`5`	`5`	`flex-direction: column;`
`6`	`6`	`justify-content: center;`
`7`		`- min-height: 300px;`
`8`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`display: flex;`
`7`	`7`	`}`
`8`	`8`
`9`		`-.buik-sort-btn {`
	`9`	`+.buik-btn.buik-sort-btn {`
`10`	`10`	`padding: 5px 16px;`
`11`	`11`
`12`	`12`	`.bce:not(.buik-is-small) & {`