Skip to content

Commit 9627e2b

Browse files
authored
feat(select): make caret rotate up/down on open/close respectively (#1218)
* feat(select): make select caret rotate on drop down open/close Also makes collapsible caret rotate on open/close. This makes both consistent to drop down menus. * fix: use common variable for transition duration
1 parent 78ab636 commit 9627e2b

File tree

6 files changed

+22
-7
lines changed

6 files changed

+22
-7
lines changed

src/components/collapsible/Collapsible.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
.collapsible-card-header-caret {
2929
position: absolute;
3030
right: 0;
31+
transition: transform $bdl-transition-duration-200ms;
3132
}
3233

3334
.btn-plain.collapsible-card-title {
@@ -43,6 +44,10 @@
4344
padding: 10px 0;
4445
}
4546

47+
&.is-open .collapsible-card-header-caret {
48+
transform: rotateZ(180deg);
49+
}
50+
4651
&.is-bordered {
4752
border: 1px solid $eees;
4853

src/components/dropdown-menu/MenuToggle.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
> .toggle-arrow {
88
flex: none;
99
margin-left: 5px;
10-
transition: transform .2s ease-in;
10+
transition: transform $bdl-transition-duration-200ms ease-in;
1111

1212
.dropdown-menu-enabled &,
1313
.is-toggled & {

src/elements/content-sidebar/SidebarSection.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@
1818
text-align: left;
1919
width: 100%;
2020

21+
.icon-caret-down {
22+
transition: transform $bdl-transition-duration-200ms;
23+
}
24+
2125
&:active,
2226
&:focus {
2327
border-bottom-color: $blue;
@@ -27,12 +31,8 @@
2731
fill: $twos;
2832
}
2933
}
30-
31-
.icon-caret-down {
32-
transform: rotateZ(-90deg);
33-
}
3434
}
3535

3636
.be .bcs-section-open .btn-plain.bcs-section-title .icon-caret-down {
37-
transform: none;
37+
transform: rotateZ(180deg);
3838
}

src/styles/_variables.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,3 +163,6 @@ $bdl-line-height: 20px;
163163

164164
// Borders
165165
$bdl-border-radius-size: 4px;
166+
167+
// Animation
168+
$bdl-transition-duration-200ms: .2s;

src/styles/common/_forms.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,14 @@ textarea {
222222
position: absolute;
223223
right: 11px;
224224
top: 15px;
225+
transition: transform $bdl-transition-duration-200ms;
225226
width: 0;
226227
}
227228

229+
.select-container .select-button[aria-expanded='true']::before {
230+
transform: rotateZ(180deg);
231+
}
232+
228233
.select-container .select-button {
229234
color: $twos;
230235
padding-right: 25px;

src/styles/common/_tables.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@import '../variables';
2+
13
/**************************************
24
* Tables
35
**************************************/
@@ -186,7 +188,7 @@
186188
path {
187189
transform: rotate(0deg);
188190
transform-origin: 50% 50%;
189-
transition: transform .25s;
191+
transition: transform $bdl-transition-duration-200ms;
190192
}
191193
}
192194
}

0 commit comments

Comments
 (0)