feat(classification): remove classify from breadcrumbs (#1549)

Author: feixuanli

i18n/en-US.properties

@@ -596,8 +596,6 @@ boxui.breadcrumb.breadcrumbLabel = Breadcrumb
 boxui.checkboxTooltip.iconInfoText = Info
 # Button to add classification on an item
 boxui.classification.add = Add
-# Button to add classification on an item
-boxui.classification.addClassification = CLASSIFY
 # Header for classification section in sidebar
 boxui.classification.classification = Classification
 # Button to edit classification on an item

src/features/classification/AddClassificationBadge.js

@@ -3,7 +3,6 @@ import * as React from 'react';
 import { FormattedMessage } from 'react-intl';
 
 import ClassifiedBadge from './ClassifiedBadge';
-import AddClassificationBadge from './AddClassificationBadge';
 import messages from './messages';
 import './Classification.scss';
 
@@ -24,8 +23,6 @@ const Classification = ({ advisoryMessage, className = '', messageStyle, name }:
     const isTooltipMessageEnabled = isClassified && hasMessage && messageStyle === STYLE_TOOLTIP;
     const isInlineMessageEnabled = isClassified && hasMessage && messageStyle === STYLE_INLINE;
 
-    // Either the add classification badge should be visible or the "not classified" text or neither
-    const isAddClassificationBadgeVisible = !isClassified && !messageStyle;
     const isNotClassifiedMessageVisible = !isClassified && messageStyle === STYLE_INLINE;
 
     return (
@@ -36,7 +33,6 @@ const Classification = ({ advisoryMessage, className = '', messageStyle, name }:
                     tooltipText={isTooltipMessageEnabled ? advisoryMessage : undefined}
                 />
             )}
-            {isAddClassificationBadgeVisible && <AddClassificationBadge />}
             {isInlineMessageEnabled && <p className="bdl-Classification-advisoryMessage">{advisoryMessage}</p>}
             {isNotClassifiedMessageVisible && (
                 <span className="bdl-Classification-missingMessage">

src/features/classification/AddClassificationBadge.scss

@@ -21,11 +21,6 @@ Renders a classification badge and advisory message.
 />
 ```
 
-**Not Classified Badge to add classification**
-```jsx
-<Classification />
-```
-
 **Not Classified Text**
 ```jsx
 <Classification messageStyle="inline" />

src/features/classification/Classification.js

@@ -1,6 +1,7 @@
 import React from 'react';
 
 import Classification from '../Classification';
+import ClassifiedBadge from '../ClassifiedBadge';
 
 describe('features/classification/Classification', () => {
     const getWrapper = (props = {}) => shallow(<Classification {...props} />);
@@ -12,9 +13,11 @@ describe('features/classification/Classification', () => {
         expect(wrapper).toMatchSnapshot();
     });
 
-    test('should render add classification badge', () => {
+    test('should render empty when classification does not exist but is editable', () => {
         const wrapper = getWrapper();
-        expect(wrapper).toMatchSnapshot();
+        expect(wrapper.find(ClassifiedBadge).length).toBe(0);
+        expect(wrapper.find('.bdl-Classification-advisoryMessage').length).toBe(0);
+        expect(wrapper.find('.bdl-Classification-missingMessage').length).toBe(0);
     });
 
     test('should render not classified message', () => {

src/features/classification/README.md

@@ -36,14 +36,6 @@ exports[`features/classification/Classification should render a classified badge
 </article>
 `;
 
-exports[`features/classification/Classification should render add classification badge 1`] = `
-<article
-  className="bdl-Classification "
->
-  <AddClassificationBadge />
-</article>
-`;
-
 exports[`features/classification/Classification should render not classified message 1`] = `
 <article
   className="bdl-Classification "

src/features/classification/__tests__/AddClassificationBadge-test.js

@@ -1,7 +1,6 @@
 // @flow
 
 export { default } from './Classification';
-export { default as AddClassificationBadge } from './AddClassificationBadge';
 export { default as ClassifiedBadge } from './ClassifiedBadge';
 export { default as classificationMessages } from './messages';
 export { default as EditClassificationButton } from './EditClassificationButton';