Skip to content

Commit ee8569f

Browse files
kritishrivastavaJeremy Press
authored andcommitted
feat(office-online): adding excel spreadsheet icon for xlsb files
1 parent 853e106 commit ee8569f

File tree

7 files changed

+22
-2
lines changed

7 files changed

+22
-2
lines changed

src/icons/file-icon/FileIcon.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ const EXTENSIONS = {
133133
]),
134134
IconFileDocument: mirror(['csv', 'dot', 'dotx', 'msg', 'odt', 'rtf', 'tsv', 'wpd', 'xhtml', 'xml', 'xsd', 'xsl']),
135135
IconFileDwg: mirror(['dwg', 'dwgzip']),
136-
IconFileExcelSpreadsheet: mirror(['xls', 'xlsx', 'xlsm']),
136+
IconFileExcelSpreadsheet: mirror(['xls', 'xlsx', 'xlsm', 'xlsb']),
137137
IconFileGoogleDocs: mirror(['gdoc']),
138138
IconFileGoogleSheets: mirror(['gsheet']),
139139
IconFileGoogleSlides: mirror(['gslide', 'gslides']),

src/icons/file-icon/__tests__/FileIcon-test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ describe('icons/file-icon/FileIcon', () => {
5656
{
5757
extension: 'xlsm',
5858
},
59+
{
60+
extension: 'xlsb',
61+
},
5962
{
6063
extension: 'zip',
6164
},

src/icons/file-icon/__tests__/__snapshots__/FileIcon-test.js.snap

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,13 @@ exports[`icons/file-icon/FileIcon should render the expected icon when extension
120120
`;
121121

122122
exports[`icons/file-icon/FileIcon should render the expected icon when extension is defined 16`] = `
123+
<IconFileExcelSpreadsheet
124+
height={32}
125+
width={32}
126+
/>
127+
`;
128+
129+
exports[`icons/file-icon/FileIcon should render the expected icon when extension is defined 17`] = `
123130
<IconFileZip
124131
height={32}
125132
width={32}

src/icons/microsoft-office/OfficeDesktopIcon.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ const OfficeDesktopIcon = ({ className, dimension = 30, extension, title }: Prop
3030
case 'xls':
3131
case 'xlsx':
3232
case 'xlsm':
33+
case 'xlsb':
3334
Component = IconExcelDesktop;
3435
break;
3536
// no default

src/icons/microsoft-office/OfficeOnlineIcon.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ const OfficeOnlineIcon = ({ className, dimension = 30, extension, title }: Props
3030
case 'xls':
3131
case 'xlsx':
3232
case 'xlsm':
33+
case 'xlsb':
3334
Component = IconExcelOnline;
3435
break;
3536
// no default

src/icons/microsoft-office/__tests__/OfficeDesktopIcon-test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ describe('icons/microsoft-office/OfficeDesktopIcon', () => {
3434
extension: 'xlsm',
3535
component: 'IconExcelDesktop',
3636
},
37+
{
38+
extension: 'xlsb',
39+
component: 'IconExcelDesktop',
40+
},
3741
].forEach(({ extension, component }) => {
3842
test('should correctly render default icon', () => {
3943
const wrapper = getWrapper({ extension });

src/icons/microsoft-office/__tests__/OfficeOnlineIcon-test.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,17 @@ describe('icons/microsoft-office/OfficeOnlineIcon', () => {
2727
component: 'IconExcelOnline',
2828
},
2929
{
30-
extension: 'xlsm',
30+
extension: 'xlsx',
3131
component: 'IconExcelOnline',
3232
},
3333
{
3434
extension: 'xlsm',
3535
component: 'IconExcelOnline',
3636
},
37+
{
38+
extension: 'xlsb',
39+
component: 'IconExcelOnline',
40+
},
3741
].forEach(({ extension, component }) => {
3842
test('should correctly render default icon', () => {
3943
const wrapper = getWrapper({ extension });

0 commit comments

Comments
 (0)