feat(content-uploader): Implement permission error handling uploads#4580
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds a new exported error constant and i18n message for upload "insufficient permissions", replaces a hard-coded error string in MultiputUpload with the constant, and updates UI rendering and tests to show the localized permission-denied message. ChangesUpload insufficient permissions error handling
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9cc5b98 to
73dcbd7
Compare
61f40f7 to
8f1e793
Compare
73dcbd7 to
e796897
Compare
85ce4c2 to
3981600
Compare
e796897 to
c88db8e
Compare
3981600 to
d975ca1
Compare
3dd35a9 to
8abe80a
Compare
d975ca1 to
2137f08
Compare
The base branch was changed.
Map the 403 access_denied_insufficient_permissions error code to a distinct, localized message in the upload list error renderer instead of falling through to the generic Something went wrong copy. Storage limit errors continue to surface their existing message.
2137f08 to
6caedd9
Compare
6caedd9 to
be7fa97
Compare
Merge Queue Status
This pull request spent 38 seconds in the queue, including 4 seconds running CI. Required conditions to merge
|
5/5 PR in the queue:
Summary by CodeRabbit
Bug Fixes
Localization
Tests