Skip to content

Conversation

@barmac
Copy link
Member

@barmac barmac commented Sep 26, 2025

Closes #50

Proposed Changes

Currently, we force-try to parse a broken expression. This PR takes advantage of strict parsing to bail out in case a syntax error is encountered.

The issue cannot be reproduced in the npm start environment, but you can link it to Desktop Modeler. Below is the demo of a diagram opened without errors:

Screen.Recording.2025-09-26.at.14.54.48.mov

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 26, 2025
@barmac barmac requested a review from marstamm September 26, 2025 12:57
@barmac
Copy link
Member Author

barmac commented Sep 26, 2025

@marstamm Since you implemented most parts of this library, I'd appreciate it if you could have a look at the change.

Add error handling to bail out on parse failure
Copy link
Collaborator

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, simple fix for large unparsable expressions. No comments from my side 👍

@barmac barmac merged commit ce771b9 into main Sep 26, 2025
5 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 26, 2025
@barmac barmac deleted the 50-test-case branch September 26, 2025 15:05
@barmac
Copy link
Member Author

barmac commented Sep 26, 2025

Released as 1.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Never ending loop when a connector is selected

2 participants