Issue with closing pre tag #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…> as not enough characters were getting stripped away before exploding into individual lines.
Owner
|
Nice catch. Looks like I was attempting to remove the closing tag using the original string length without accounting for the first tag already being stripped. |
ghost
assigned
Collaborator
Author
|
Ah, that's it. I couldn't workout where exactly the discrepancy was coming from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the final line of code was ending up as </pre as not enough characters were getting stripped away before exploding into individual lines.
Brady, please check this over - if you check your own rendered gists against the develop branch, you should see that the last line of the table data cell for line_data end up as:
which is clearly invalid markup.