Feature/refund on failure #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a refund option in the swap sale flow. If the swap expires the user will be presented with an option to get his money out of the contract. The flow also changed a little - now we ask the user first to switch to a different chain and then he sees the target chain swap that we found. We check the times on his swap and on the target swap. If the target swap time left is less than 20 sec we prevent the user from revealing the secrets as there is not enough time for his tx to go through. (unless he sets a mega high tx gas, but he won’t have the time for this in the metamask UI…)
cducrest
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a refund option in the swap sale flow. If the swap expires the user will be presented with an option to get his money out of the contract.
The flow also changed a little - now we ask the user first to switch to a different chain and then he sees the target chain swap that we found. We check the times on his swap and on the target swap. If the target swap time left is less than 20 sec we prevent the user from revealing the secrets as there is not enough time for his tx to go through. (unless he sets a mega high tx gas, but he won’t have the time for this in the metamask UI…)
Some screenshots from the new UI: