Bump actions/upload-artifact to v4
#691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsaphel
changed the title
actions/upload-artifact to v4
|
Thank you @itsaphel |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 76 76
Lines 6821 6821
=======================================
Hits 5950 5950
Misses 871 871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs job seems to be erroring due to the deprecation of
actions/upload-artifact@v3: https://github.com/braindecode/braindecode/actions/runs/13089486769/job/36524496412?pr=690This PR bumps it to v4. I reviewed the migration guide here: I think it should be fine, but I don't know for sure what the value of
GITHUB_ARTIFACT_URLis in CircleCI. I've checked the archive of the last successful docs build - it doesn't look like there's any hidden files of concern.This PR will need a
no changeloglabel