Skip to content

fix string->int failure in bad id test #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IgorTatarnikov merged 1 commit into from
Jan 26, 2026
Merged

fix string->int failure in bad id test #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/test_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import re
from pathlib import Path

import numpy as np
import pytest

from morphapi.api.allenmorphology import AllenMorphology
Expand Down Expand Up @@ -159,8 +160,8 @@ def test_allen_morphology_download(tmpdir):
)

# Test failure
neurons_df.loc[2, "id"] = "BAD ID"
neurons_df.loc[2, "id"] = np.iinfo(np.int64).min # intentionally bad ID
neurons = am.download_neurons(neurons_df["id"].values)

assert neurons[0].data_file.name == "BAD ID.swc"
assert neurons[0].data_file.name == f"{np.iinfo(np.int64).min}.swc"
assert neurons[0].points is None