feat: pytorch math-operations-a #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoming0625
requested changes
Feb 20, 2023
Member
chaoming0625
left a comment
chaoming0625
left a comment
There was a problem hiding this comment.
A good PR. Minor bugs to fix:
alphais redundant inadd()function?- Many functions have incorrect return typing. They should be
-> Optional[Array]rather thanArray.
|
|
||
| def add(input: Union[jax.Array, Array, jnp.number], | ||
| other: Union[jax.Array, Array, jnp.number], | ||
| *, alpha: Optional[jnp.number] = 1, |
Author
There was a problem hiding this comment.
In Pytorch, the add func is not only "add". It also means "Adds other, scaled by alpha, to input.", and alpha is used in line 134.
Member
|
One more thing, add these functions in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在compat_pytorch中增加了对math-operations的支持，并添加了相关的单元测试。