update data/ test lists #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: d2648bc | Previous: 082f2d6 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2272651145 ns/iter (± 18004997) |
2218583461 ns/iter (± 10006252) |
1.02 |
rule-match-first-request/brave-list |
1064315 ns/iter (± 9900) |
1018814 ns/iter (± 4755) |
1.04 |
blocker_new/brave-list |
158049635 ns/iter (± 1132039) |
147454902 ns/iter (± 2479150) |
1.07 |
blocker_new/brave-list-deserialize |
69479598 ns/iter (± 1092071) |
60906410 ns/iter (± 765032) |
1.14 |
memory-usage/brave-list-initial |
18858489 ns/iter (± 3) |
17549140 ns/iter (± 3) |
1.07 |
memory-usage/brave-list-initial/max |
66961293 ns/iter (± 3) |
64817658 ns/iter (± 3) |
1.03 |
memory-usage/brave-list-initial/alloc-count |
1616098 ns/iter (± 3) |
1515544 ns/iter (± 3) |
1.07 |
memory-usage/brave-list-1000-requests |
2551906 ns/iter (± 3) |
2505592 ns/iter (± 3) |
1.02 |
memory-usage/brave-list-1000-requests/alloc-count |
68803 ns/iter (± 3) |
66155 ns/iter (± 3) |
1.04 |
url_cosmetic_resources/brave-list |
212527 ns/iter (± 2087) |
209946 ns/iter (± 2783) |
1.01 |
cosmetic-class-id-match/brave-list |
4367110 ns/iter (± 1201865) |
4331548 ns/iter (± 1117461) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
atuchin-m
force-pushed
the
update-test-lists
branch
from
148e9a6 to
cfa2c4f
Compare
boocmp
approved these changes
Sep 12, 2025
atuchin-m
force-pushed
the
update-test-lists
branch
from
cfa2c4f to
d2648bc
Compare
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: d2648bc | Previous: 082f2d6 | Ratio |
|---|---|---|---|
blocker_new/brave-list-deserialize |
69479598 ns/iter (± 1092071) |
60906410 ns/iter (± 765032) |
1.14 |
This comment was automatically generated by workflow using github-action-benchmark.
boocmp
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR:
Brave Default Privacy Filtersfetching and merge it to the main test list (because the main list was split into 2);node data/update-lists.js 1.0.14702 1.0.956 1.0.113;